Implement Phases 1-5: skeleton, OAuth, categories, video sync/feed, playback
- FastAPI + PostgreSQL + Alembic + React/Vite skeleton, Docker Compose, healthcheck
- Google OAuth (single allowed account), encrypted refresh token storage
- Subscriptions sync with pagination, uploads playlist batch fetch
- Categories CRUD, many-to-many channel assignment, category filtering
- Video sync (playlistItems + videos.list batching), cached feed with cursor
pagination, background scheduler (APScheduler)
- Video detail page with YouTube embed player
- SPA fallback routing, optimistic UI updates, client-side query caching
40 backend tests covering OAuth allow-list, sync idempotency, cascade deletes,
cursor pagination, and category filtering.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-16 18:44:30 +00:00
|
|
|
from datetime import datetime, timezone
|
|
|
|
|
|
|
|
|
|
import pytest
|
|
|
|
|
from fastapi.testclient import TestClient
|
|
|
|
|
|
|
|
|
|
from app.core.auth_dependency import require_session
|
|
|
|
|
from app.db import get_db
|
|
|
|
|
from app.main import app
|
|
|
|
|
from app.models.category import Category
|
|
|
|
|
from app.models.channel import Channel
|
|
|
|
|
from app.models.channel_category import channel_categories
|
|
|
|
|
from app.models.video import Video
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.fixture
|
|
|
|
|
def client(db_session):
|
|
|
|
|
def _get_db_override():
|
|
|
|
|
yield db_session
|
|
|
|
|
|
|
|
|
|
app.dependency_overrides[get_db] = _get_db_override
|
|
|
|
|
app.dependency_overrides[require_session] = lambda: None
|
2026-09-16 18:56:17 +00:00
|
|
|
# Deliberately not using `with TestClient(app)`: that runs the app's
|
|
|
|
|
# lifespan, which would try to reach the real MeTube instance and DB
|
|
|
|
|
# (see AGENTS.md: MeTube network calls in tests must be opt-in only).
|
|
|
|
|
yield TestClient(app)
|
Implement Phases 1-5: skeleton, OAuth, categories, video sync/feed, playback
- FastAPI + PostgreSQL + Alembic + React/Vite skeleton, Docker Compose, healthcheck
- Google OAuth (single allowed account), encrypted refresh token storage
- Subscriptions sync with pagination, uploads playlist batch fetch
- Categories CRUD, many-to-many channel assignment, category filtering
- Video sync (playlistItems + videos.list batching), cached feed with cursor
pagination, background scheduler (APScheduler)
- Video detail page with YouTube embed player
- SPA fallback routing, optimistic UI updates, client-side query caching
40 backend tests covering OAuth allow-list, sync idempotency, cascade deletes,
cursor pagination, and category filtering.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-16 18:44:30 +00:00
|
|
|
del app.dependency_overrides[get_db]
|
|
|
|
|
del app.dependency_overrides[require_session]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_video_by_youtube_id(client, db_session):
|
|
|
|
|
channel = Channel(youtube_channel_id="chanA", title="Channel A", subscribed=True)
|
|
|
|
|
db_session.add(channel)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
category = Category(name="Linux", slug="linux", sort_order=0)
|
|
|
|
|
db_session.add(category)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
db_session.execute(channel_categories.insert().values(channel_id=channel.id, category_id=category.id))
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
video = Video(
|
|
|
|
|
youtube_video_id="vid1",
|
|
|
|
|
channel_id=channel.id,
|
|
|
|
|
title="Video One",
|
|
|
|
|
description="desc",
|
|
|
|
|
published_at=datetime(2026, 9, 10, tzinfo=timezone.utc),
|
|
|
|
|
duration_seconds=125,
|
|
|
|
|
youtube_url="https://www.youtube.com/watch?v=vid1",
|
|
|
|
|
)
|
|
|
|
|
db_session.add(video)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
resp = client.get("/api/videos/vid1")
|
|
|
|
|
assert resp.status_code == 200
|
|
|
|
|
body = resp.json()
|
|
|
|
|
assert body["youtube_video_id"] == "vid1"
|
|
|
|
|
assert body["channel"]["id"] == channel.id
|
|
|
|
|
assert body["categories"] == [{"id": category.id, "name": "Linux"}]
|
|
|
|
|
assert body["local"]["available"] is False
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_get_video_not_found(client):
|
|
|
|
|
resp = client.get("/api/videos/missing")
|
|
|
|
|
assert resp.status_code == 404
|
2026-09-16 18:56:17 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def _seed_single_video(db_session, youtube_video_id="vid1"):
|
|
|
|
|
channel = Channel(youtube_channel_id="chanA", title="Channel A", subscribed=True)
|
|
|
|
|
db_session.add(channel)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
video = Video(
|
|
|
|
|
youtube_video_id=youtube_video_id,
|
|
|
|
|
channel_id=channel.id,
|
|
|
|
|
title="Video One",
|
|
|
|
|
published_at=datetime(2026, 9, 10, tzinfo=timezone.utc),
|
|
|
|
|
youtube_url=f"https://www.youtube.com/watch?v={youtube_video_id}",
|
|
|
|
|
)
|
|
|
|
|
db_session.add(video)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
db_session.refresh(video)
|
|
|
|
|
return video
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_download_video_enqueues(client, db_session, monkeypatch):
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
"app.services.metube_client.MeTubeClient.enqueue_video", lambda self, u, p: {"status": "ok"}
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
resp = client.post(f"/api/videos/{video.youtube_video_id}/download")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 200
|
|
|
|
|
assert resp.json()["status"] == "queued"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_download_video_metube_rejects(client, db_session, monkeypatch):
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
"app.services.metube_client.MeTubeClient.enqueue_video",
|
|
|
|
|
lambda self, u, p: {"status": "error", "msg": "bad url"},
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
resp = client.post(f"/api/videos/{video.youtube_video_id}/download")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 502
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_download_video_second_click_returns_same_job(client, db_session, monkeypatch):
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
"app.services.metube_client.MeTubeClient.enqueue_video", lambda self, u, p: {"status": "ok"}
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
r1 = client.post(f"/api/videos/{video.youtube_video_id}/download").json()
|
|
|
|
|
r2 = client.post(f"/api/videos/{video.youtube_video_id}/download").json()
|
|
|
|
|
|
|
|
|
|
assert r1["requested_at"] == r2["requested_at"]
|
|
|
|
|
|
|
|
|
|
from app.models.download_job import DownloadJob
|
|
|
|
|
|
|
|
|
|
assert db_session.query(DownloadJob).count() == 1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_download_status_not_downloaded(client, db_session):
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
resp = client.get(f"/api/videos/{video.youtube_video_id}/download-status")
|
|
|
|
|
assert resp.json()["status"] == "not_downloaded"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_recheck_local_downgrades_to_unknown_when_media_missing(client, db_session, monkeypatch):
|
|
|
|
|
from app.models.download_job import DownloadJob
|
|
|
|
|
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
job = DownloadJob(video_id=video.id, status="completed", media_url="http://metube.local/download/f.mp4")
|
|
|
|
|
db_session.add(job)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
monkeypatch.setattr("app.services.metube_client.MeTubeClient.check_media", lambda self, url: False)
|
|
|
|
|
|
|
|
|
|
resp = client.post(f"/api/videos/{video.youtube_video_id}/recheck-local")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 200
|
|
|
|
|
assert resp.json()["status"] == "unknown"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_recheck_local_keeps_completed_when_media_reachable(client, db_session, monkeypatch):
|
|
|
|
|
from app.models.download_job import DownloadJob
|
|
|
|
|
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
job = DownloadJob(video_id=video.id, status="completed", media_url="http://metube.local/download/f.mp4")
|
|
|
|
|
db_session.add(job)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
monkeypatch.setattr("app.services.metube_client.MeTubeClient.check_media", lambda self, url: True)
|
|
|
|
|
|
|
|
|
|
resp = client.post(f"/api/videos/{video.youtube_video_id}/recheck-local")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 200
|
|
|
|
|
assert resp.json()["status"] == "completed"
|
2026-09-16 19:47:35 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_delete_download_requires_completed_job(client, db_session):
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
resp = client.delete(f"/api/videos/{video.youtube_video_id}/download")
|
|
|
|
|
assert resp.status_code == 400
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_delete_download_success(client, db_session, monkeypatch):
|
|
|
|
|
from app.models.download_job import DownloadJob
|
|
|
|
|
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
job = DownloadJob(
|
|
|
|
|
video_id=video.id,
|
|
|
|
|
status="completed",
|
|
|
|
|
metube_job_id="vid1.vid1",
|
|
|
|
|
media_url="http://metube.local/download/f.mp4",
|
|
|
|
|
)
|
|
|
|
|
db_session.add(job)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
calls = {}
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
"app.services.metube_client.MeTubeClient.delete_download",
|
|
|
|
|
lambda self, metube_job_id: calls.setdefault("id", metube_job_id) or {"status": "ok"},
|
|
|
|
|
)
|
2026-09-16 20:01:41 +00:00
|
|
|
monkeypatch.setattr("app.services.metube_client.MeTubeClient.check_media", lambda self, url: False)
|
2026-09-16 19:47:35 +00:00
|
|
|
|
|
|
|
|
resp = client.delete(f"/api/videos/{video.youtube_video_id}/download")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 200
|
|
|
|
|
assert resp.json()["status"] == "deleted"
|
|
|
|
|
assert resp.json()["media_url"] is None
|
|
|
|
|
assert calls["id"] == "vid1.vid1"
|
|
|
|
|
|
|
|
|
|
db_session.refresh(job)
|
|
|
|
|
assert job.status == "deleted"
|
|
|
|
|
assert job.media_url is None
|
2026-09-16 20:01:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_delete_download_file_still_present_returns_409(client, db_session, monkeypatch):
|
|
|
|
|
"""MeTube can accept /delete and still leave the file on disk if its own
|
|
|
|
|
DELETE_FILE_ON_TRASHCAN config is off -- we must not lie about that."""
|
|
|
|
|
from app.models.download_job import DownloadJob
|
|
|
|
|
|
|
|
|
|
video = _seed_single_video(db_session)
|
|
|
|
|
job = DownloadJob(
|
|
|
|
|
video_id=video.id,
|
|
|
|
|
status="completed",
|
|
|
|
|
metube_job_id="vid1.vid1",
|
|
|
|
|
media_url="http://metube.local/download/f.mp4",
|
|
|
|
|
)
|
|
|
|
|
db_session.add(job)
|
|
|
|
|
db_session.commit()
|
|
|
|
|
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
"app.services.metube_client.MeTubeClient.delete_download", lambda self, metube_job_id: {"status": "ok"}
|
|
|
|
|
)
|
|
|
|
|
monkeypatch.setattr("app.services.metube_client.MeTubeClient.check_media", lambda self, url: True)
|
|
|
|
|
|
|
|
|
|
resp = client.delete(f"/api/videos/{video.youtube_video_id}/download")
|
|
|
|
|
|
|
|
|
|
assert resp.status_code == 409
|
|
|
|
|
|
|
|
|
|
db_session.refresh(job)
|
|
|
|
|
assert job.status == "completed"
|
|
|
|
|
assert job.media_url == "http://metube.local/download/f.mp4"
|